Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding certain files from **manifest** after processing. #125

Open
aeomer opened this issue Jan 4, 2016 · 1 comment
Open

Excluding certain files from **manifest** after processing. #125

aeomer opened this issue Jan 4, 2016 · 1 comment

Comments

@aeomer
Copy link

aeomer commented Jan 4, 2016

I have a use case related to performance which I believe is quite common.

Consider having a number of image or font assets which are referenced from and only from a CSS file. gulp-rev-all will properly transform the names of those assets to include a hash and ensure the references in the CSS file are updated. All good so far. However, it will also create an entry in the manifest for each one of what could be hundreds of asset files, none of which are referenced from anywhere other than the CSS file. This leads to a huge manifest from which only a few references are ever used in code. (This is the simple case; there is a slightly more complex one below.)
The existing options do not seem to cover excluding files from the manifest, only from the entire file stream. To complete the use case, a number of the image files and other files referenced in the CSS may be referenced in the code, too - just a few, not all of them. This means a naive fix, such as flag excluding external resources to a CSS file from the manifest, is not desirable.

Does anyone have a demonstrable solution to this issue? I was unable to make gulp-ignore do this.

If not, could we add an option to manifest generation which exclude renamed files from the manifest which match an array of glob patterns matching the source name?

@aeomer aeomer changed the title Excluding certain files from manifest after processing. Excluding certain files from **manifest** after processing. Jan 5, 2016
@aeomer
Copy link
Author

aeomer commented Jan 7, 2016

I think smysnk is on vacation. ;-)

I am now doing this by post processing the manifests. However, it is a clear use case which matches with the original reason this plugin was created.

Would anyone like to suggest how they would like to see this implemented rather than me blindly adding the functionality and making a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant