Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for automated testing #7

Open
andreas-bulling opened this issue May 4, 2021 · 7 comments
Open

Support for automated testing #7

andreas-bulling opened this issue May 4, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@andreas-bulling
Copy link
Contributor

andreas-bulling commented May 4, 2021

Hi,

Do you see a chance to test with/support the latest OSS Sharelatex version (2.6.1 at the moment I believe) and, in general, future latest versions? There is unfortunately no changelog for the things they implement as far as I know. And the open source version is generally put in second place behind the commercial version. But it would still be nice to be current with the small improvements in Sharelatex that they are willing to share with the community.

@andreas-bulling andreas-bulling changed the title Support for version 2.6.1 Support for version 2.6.1? May 4, 2021
@smhaller
Copy link
Owner

smhaller commented May 4, 2021

Lets see if we could do some automated testing with something like https://github.com/rroemhild/docker-test-openldap .

@andreas-bulling
Copy link
Contributor Author

good idea - I guess one line of tests is about whether the changes can still be applied to the updated codebase. A second is what you suggest - whether the changes functionally work with the new Sharelatex version.

@smhaller
Copy link
Owner

I just tried 2.6.1 on my test instance and it seems to work. I updated the repo (but i still didn't look into the CI/CD for the latest versions.. lets see maybe this weekend)

smhaller added a commit that referenced this issue May 10, 2021
…able which admin interface is used (via .env file)
@haslersn
Copy link

I can confirm that 2.6.1 works; note that I used a different Dockerfile (using --build-arg BASE=docker.io/sharelatex/sharelatex:2.6.1).

@wixaw
Copy link

wixaw commented Jul 2, 2021

Hello
I am discovering your LDAP custom. It's great, but I am afraid of the long time! If this is broken I would not want to be blocked with a old version
What do you think ? It's safe ?

And I would need to tie two branches
Branch1 ou=people for our users (id = cn)(all)
Branch2 ou=peopleext for our partners (id = uid)(memberof=cn=xxxxxx)

It's possible ?
Thanks

@smhaller
Copy link
Owner

smhaller commented Jul 2, 2021

2.6.1 is working. I keep this open to remind that I/we should find a way for automated testing.

For the two branches i think you can write a filter like: (|(FIRSTFILTER)(SECONDFILTER))

@smhaller smhaller changed the title Support for version 2.6.1? Support for automated testing Jul 2, 2021
@smhaller
Copy link
Owner

3.0.1 is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants