Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP contacts not waiting for LDAP server's answer if "await" missing #61

Open
Wurzelmann opened this issue Nov 8, 2024 · 1 comment
Open

LDAP contacts not waiting for LDAP server's answer if "await" missing #61

Wurzelmann opened this issue Nov 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Wurzelmann
Copy link
Contributor

We had problems getting a response from our LDAP server until we figured out we needed to patch a line in services/web/app/src/Features/Contacts/ContactController.js:

the line
const ldapcontacts = getLdapContacts(contacts)

needs to be

const ldapcontacts = await getLdapContacts(contacts)

otherwise we'll just receive a "Promise pending" in the logs and the LDAP contacts will be missing from the user's contacts.
@yzx9

This comment was marked as off-topic.

Sign in to view
@yzx9 yzx9 closed this as completed Nov 9, 2024
@yzx9 yzx9 reopened this Nov 9, 2024
@yzx9 yzx9 added the bug Something isn't working label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wurzelmann @yzx9