Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to skip login page if OAuth provider is registered #42

Open
xathon opened this issue Jan 5, 2024 · 3 comments · May be fixed by #43
Open

Provide an option to skip login page if OAuth provider is registered #42

xathon opened this issue Jan 5, 2024 · 3 comments · May be fixed by #43
Labels
enhancement New feature or request

Comments

@xathon
Copy link

xathon commented Jan 5, 2024

We are using OAuth with our Overleaf server, which causes the "regular" login to stop working. It should be possible to tell Overleaf to get from the login page directly to the OAuth provider.

@xathon xathon linked a pull request Jan 5, 2024 that will close this issue
@yzx9
Copy link
Collaborator

yzx9 commented Jan 6, 2024

Thanks for your PR. I noticed in the PR that when OAuth is enabled, the regular account password login method ceases to function. Is this the intended outcome? I believe this would be better suited as a separate configuration.

@xathon
Copy link
Author

xathon commented Jan 6, 2024

That wasn't intended, but it was the behavior I was seeing once I enabled OAuth on the current live code. The regular username/password login only threw an error, so I figured it was disabled by OAuth and wanted to skip it completely. If that's in fact not intended, then this should definitely be a setting, that's true.

@yzx9 yzx9 added the enhancement New feature or request label Jan 9, 2024
@yzx9
Copy link
Collaborator

yzx9 commented Jan 9, 2024

It seems you are indicating that a bug is causing the username/password login to fail only when OAuth2 services are enabled. This behavior is certainly not intended. I have reviewed our current codebase and haven't identified any obvious errors that could be causing this login issue. To address this effectively, could you please create a new issue detailing this specific problem? I will investigate it further.

Regarding the current issue, I understand its significance. However, the proposed Pull Request introduces a BREAKING CHANGE. I would be more inclined to approve it if the change were implemented as an optional feature. This approach would allow users more flexibility in how they integrate this update.

smhaller added a commit that referenced this issue Jun 26, 2024
…oes not use ldap but oauth - then there is no login page but a redirect to the oauth provider. Closes issue #42 and pull request #43.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants