Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul webpack build #309

Open
daedalus28 opened this issue Feb 20, 2020 · 2 comments
Open

Overhaul webpack build #309

daedalus28 opened this issue Feb 20, 2020 · 2 comments
Labels
help wanted

Comments

@daedalus28
Copy link
Contributor

Our current build process means that we have to avoid using async/await in our actual source because it can cause regeneratorRuntime errors that, honestly, we don't fully understand.

It's led to insanity like #308 - which, while clever, leads to a terrible developer UX for contributors.
@chief10
Copy link

chief10 commented Mar 18, 2020 •
edited
Loading

When does this happen @daedalus28 ? I added async/await back into the code to reproduce the error during the build process but wasn't able to.

@daedalus28
Copy link
Contributor Author

daedalus28 commented Mar 25, 2020 •
edited
Loading

Hi @chief10! The error doesn't happen during build time, it shows up when end users try to use the bundled code.

It may not be relevant, but the app we saw this issue on was using create-react-app specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daedalus28 @chief10