Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break into smaller modules? #33

Open
rohit-gohri opened this issue Nov 20, 2018 · 3 comments
Open

Break into smaller modules? #33

rohit-gohri opened this issue Nov 20, 2018 · 3 comments
Labels
code
Milestone
3.0

Comments

@rohit-gohri
Copy link
Contributor

If one app only needs cfg (eg. https://github.com/smartprix/pg_backup) it needs to include whole of sm-utils with all it's dependencies that are of no use to it.
We should seperate the modules and keep this as a legacy module which just imports and exports them.
@rohit-gohri rohit-gohri added this to the 3.0 milestone Nov 20, 2018
@hit12369
Copy link
Member

Managing so many repos might be problematic, so either we can restructure it so that it supports import cfg from 'sm-utils/cfg', or adopt a monorepo structure.

@rohit-gohri
Copy link
Contributor Author

Mono repo seems like a better idea since 'sm-utils/cfg' will still lead to unneeded dependencies

@rohit-gohri
Copy link
Contributor Author

For monorepo: https://rushjs.io/ or https://github.com/lerna/lerna

@rohit-gohri rohit-gohri mentioned this issue Jun 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@hit12369 @rohit-gohri