Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[File] Export File as a class instead of a function #16

Open
rohit-gohri opened this issue Aug 29, 2018 · 3 comments
Open

[File] Export File as a class instead of a function #16

rohit-gohri opened this issue Aug 29, 2018 · 3 comments
Labels
code file major-version This change is scheduled for next major version.
Milestone
3.0

Comments

@rohit-gohri
Copy link
Contributor

No description provided.

@rohit-gohri
Copy link
Contributor Author

Exports should be consistent across the module. This the only one that is being exported as a function

@smartprix
Copy link
Collaborator

That'll be a breaking change.

@rohit-gohri
Copy link
Contributor Author

Yes, this should be changed whenever the next major version is released. We could export the function as file and class as File

@hit12369 hit12369 added the major-version This change is scheduled for next major version. label Sep 17, 2018
@rohit-gohri rohit-gohri added this to the 3.0 milestone Nov 5, 2018
@rohit-gohri rohit-gohri changed the title Export File as a class instead of a function [File] Export File as a class instead of a function Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code file major-version This change is scheduled for next major version.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@hit12369 @rohit-gohri