-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent failures causing node to panic #443
Comments
I wondered if this is related: deeplay-io/nice-grpc#609 Though the |
EDIT: looks like package-lock.json has grpc-js 1.10.8 at current head: zitadel-node/package-lock.json Line 175 in cd68a02
My notes indicated some 1.10 versions may cause issues. deeplay-io/nice-grpc#609 (comment) though v1.10.8 was not listed at the time. I've forgotten why. You could try bumping grpc-js to latest version and see what happens. But it may be a deeper issue, since I think I had a reason for listing only those bad 2 versions at the time and not a wider range. |
Unfortunately as evidenced by this log, adding my own dependency hasn't changed the fact the zitadel-node package is using or wants to use 1.10.9. Just ended up with both in the yarn.lock:
Not sure how to override this to force it to use 1.11.1. Edit: Have since learned about resolutions, added this to package.json, trying again:
Edit2: Come back with bad news:
same issue and the log is nice enough to show it's the newer version. |
We've ended up wrapping the calls this library makes in our code with a try/catch and returning a 503 if there's an exception raised so the client can decide to retry the request. If retry friendly exceptions were bubbled up from nice grpc it would be nice if this library had its own retry mechanism to attempt to smooth out transient issues but as this mitigates our customer affecting issue well enough I'm happy to just leave this issue up for future comments or closure. |
Bit of a strange one but figured I'd ask, I've got an issue where if a nodejs microservice is idle for some time (not known how long yet for a pattern) and then receives a request which requires a hit on the
/zitadel.management.v1.ManagementService/GetMyOrg
method, there's a high chance it'll crash the nodejs process with an uncaught exception.If you need any more information I'll try to provide it for you.
I've enabled the following environment variables for information:
Debug level log for the failed call:
Debug level log for a successful call of the same endpoint (after hitting refresh a few times after the container is live again):
The text was updated successfully, but these errors were encountered: