Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resumption of SubscribeVehicleData with several data items #104

Open
GetmanetsIrina opened this issue Aug 27, 2018 · 1 comment
Open

Resumption of SubscribeVehicleData with several data items #104

GetmanetsIrina opened this issue Aug 27, 2018 · 1 comment
Assignees
Labels

Comments

@GetmanetsIrina
Copy link

According to current requirements for SubscribeVehicleData with several data items SDL must resume the list of data in one SubscribeVD request, but in proposal https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0190-resumption-data-error-handling.md this requirement is redefined.

So there are 2 ways to cover the resumption of SubscribeVehicleData with several data items within handling of the errors from HMI:

  1. According to current requirements SDL will resume SubscribeVehicleData with several data items with all data in one request like in
    subscrbevdresumption
    and SDL will check general code of SubscribeVehicleData response and also each internal result code for each data.
    In case general code will be SUCCESS but some internal resultCode will be not SUCCESS (e.g VehicleInfo.SubscribeVehicleData( code:0, gps:{ dataType = VEHICLEDATA_GPS, resultCode = SUCCESS }, speed: { dataType = VEHICLEDATA_SPEED, resultCode = VEHICLE_DATA_NOT_AVAILABLE })) SDL will fail the resumption and will revert all data for current app.

  2. According to proposal SDL resumes VD data in separated SubscribeVehicleData requests, each request for the resuming of one data item and in this case SDL will check only general resultCode:
    image

What behavior is preferable for you?

We propose to use and implement the behavior according to current requirements (item 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants