Fixed queued menu updates failing #1958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem_context_change
Signed-off-by: NicoleYarroch <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1958 +/- ##
===========================================
+ Coverage 83.65% 83.66% +0.01%
===========================================
Files 441 441
Lines 22534 22546 +12
===========================================
+ Hits 18851 18864 +13
+ Misses 3683 3682 -1 |
NicoleYarroch
added
bug
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
joeljfischer
suggested changes
Apr 7, 2021
Comment on lines
+408
to
+409
| self.queuedAddMenuCells = addCells; | ||
| self.queuedDeleteMenuCells = deleteCells; |
There was a problem hiding this comment.
Can this not use self.waitingUpdateMenuCells instead?
|
Canceling work on this to work on the menu manager refactor instead #1901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1957
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Test cases added to the SDLMenuManagerSpec to test sending the queued menu with dynamic updates turned on as well as off.
Core Tests
Updated the menu with new menu cells while the current menu is still uploading.
Core version / branch / commit hash / module tested against:
HMI name / version / branch / commit hash / module tested against:
Summary
Fixed menu updates failing if a new menu is sent while the current menu is still being uploaded. The new menu updates would be queued but when the current menu finished uploading, the current menu would be sent again instead of the queued menu.
Changelog
Bug Fixes
Tasks Remaining:
CLA