Add CloseApplication RPC tests #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +44,7 @@ | |||
| ./test_scripts/Smoke/API/044_AlertManeuver_Non_Media_PositiveCase_SUCCESS.lua | |||
| ./test_scripts/Smoke/API/045_PerformAudioPassThru_Non_Media_PositiveCase_SUCCESS.lua | |||
| ./test_scripts/Smoke/API/048_GetSystemCapabilityRequest_SUCCESS.lua | |||
| ./test_scripts/API/CloseApplication/001_Success_flow.lua | |||
There was a problem hiding this comment.
@jacobkeeler as I know we have no practice to add feature tests to smoke tests list. But I like this practice. Can we add other delivered features success flow to smoke_tests.txt
There was a problem hiding this comment.
Agreed, at the very least the base success cases should be added for new RPCs. It seems that this hasn't been done for the app service RPCs, so I'll submit a PR for that.
Jack-Byrne
approved these changes
Jul 9, 2019
Jack-Byrne
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check smartdevicelink/sdl_core#2948
This PR is ready for review.
Summary
Add base CloseApplication RPC tests
ATF version
develop
Changelog
Enhancements
CLA