From aa8f1eb11e1255cc0e8ce6790d544c8a509f46bc Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Tue, 23 Jan 2024 23:13:39 -0500 Subject: [PATCH 01/11] WIP: cleanup --- CODEOWNERS | 81 +++++++++++++++++++----------------------------------- 1 file changed, 29 insertions(+), 52 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 83505b0ed8c..b186b4c7619 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -2,37 +2,32 @@ # 1. Per Github docs: "Order is important; the last matching pattern takes the most precedence." # Please define less specific codeowner paths before more specific codeowner paths in order for the more specific rule to have priority -# Misc -/core/store @samsondav @jmank88 -/core/chains @samsondav -/core/logger @jmank88 -/core/internal @samsondav @jmank88 +# Core +/core @smartcontractkit/foundations # Chains /common @smartcontractkit/integrations -/core/chains/evm @samsondav @prashantkumar1982 -/core/chains/evm/headtracker @pinebit @samsondav @prashantkumar1982 -/core/chains/evm/client @samsondav @prashantkumar1982 -/core/chains/evm/log @jmank88 @prashantkumar1982 @connorwstein -/core/chains/evm/logpoller @reductionista @connorwstein -/core/chains/cosmos @archseer @cfal +/core/chains/ @smartcontractkit/integrations # Services /core/services/cron @samsondav -/core/services/directrequest @connorwstein @samsondav -/core/services/feeds @jkongie +/core/services/directrequest @smartcontractkit/keepers +/core/services/feeds @smartcontractkit/mercury-team + +# To be deprecated in Chainlink V3 /core/services/fluxmonitorv2 @jkongie @PiotrTrzpil @connorwstein -/core/services/health @samsondav -/core/services/job @connorwstein -/core/services/keystore @RyanRHall +/core/services/health @smartcontractkit/foundations +/core/services/job @smartcontractkit/ccip +/core/services/keystore @smartcontractkit/keepers /core/services/ocr* @connorwstein @samsondav -/core/services/ocr2 @jmank88 @krehermann +/core/services/ocr2 @smartcontractkit/foundations /core/services/periodicbackup @PiotrTrzpil @samsondav -/core/services/pg @samsondav -/core/services/pipeline @connorwstein @prashantkumar1982 -/core/services/synchronization -/core/services/telemetry -/core/services/relay/evm/mercury @samsondav @sdrug @martin-cll +/core/services/pg @smartcontractkit/foundations @samsondav +/core/services/pipeline @smartcontractkit/foundations @smartcontractkit/integrations +/core/services/synchronization @smartcontractkit/foundations +/core/services/telemetry @smartcontractkit/telemetry +/core/services/relay/evm/mercury @smartcontractkit/mercury-team +/core/services/webhook @smartcontractkit/foundations @smartcontractkit/integrations # VRF-related services /core/services/vrf @smartcontractkit/vrf-team @@ -48,27 +43,16 @@ /core/services/keeper @smartcontractkit/keepers /core/services/ocr2/plugins/ocr2keeper @smartcontractkit/keepers -/core/services/webhook @samsondav - # Chainlink Functions core/services/functions @smartcontractkit/functions core/services/ocr2/plugins/functions @smartcontractkit/functions -core/services/s4 @pinebit @bolekk -core/service/ocr2/plugins/s4 @pinebit @bolekk -core/services/ocr2/plugins/threshold @KuphJr @bolekk -core/services/relay/evm/functions.go @bolekk @justinkaseman @KuphJr -core/services/relay/evm/functions @bolekk @justinkaseman @KuphJr +core/services/s4 @smartcontractkit/functions +core/service/ocr2/plugins/s4 @smartcontractkit/functions +core/services/ocr2/plugins/threshold @smartcontractkit/functions +core/services/relay/evm/functions @smartcontractkit/functions +core/services/relay/evm/functions @smartcontractkit/functions core/scripts/functions @smartcontractkit/functions -core/scripts/gateway @bolekk @pinebit - -# API -/core/web @jkongie - -# CLI -/core/cmd @jkongie @jmank88 @samsondav - -# UI -/operator-ui/ @DeividasK @jkongie +core/scripts/gateway @smartcontractkit/functions # Contracts /contracts/ @RensR @@ -83,10 +67,10 @@ core/scripts/gateway @bolekk @pinebit /contracts/**/*upkeep* @smartcontractkit/keepers /contracts/**/*automation* @smartcontractkit/keepers /contracts/**/*functions* @smartcontractkit/functions -/contracts/**/*llo-feeds* @austinborn @Fletch153 +/contracts/**/*llo-feeds* @smartcontrackit/mercury-team /contracts/**/*vrf* @smartcontractkit/vrf-team /contracts/**/*l2ep* @simsonraj -/contracts/**/*operatorforwarder* @essamhassan +/contracts/**/*operatorforwarder* @RensR /contracts/src/v0.8/automation @smartcontractkit/keepers /contracts/src/v0.8/functions @smartcontractkit/functions @@ -94,7 +78,7 @@ core/scripts/gateway @bolekk @pinebit /contracts/src/v0.8/l2ep @simsonraj /contracts/src/v0.8/llo-feeds @austinborn @Fletch153 # TODO: mocks folder, folder should be removed and files moved to the correct folders -/contracts/src/v0.8/operatorforwarder @essamhassan +/contracts/src/v0.8/operatorforwarder @RensR /contracts/src/v0.8/shared @RensR # TODO: tests folder, folder should be removed and files moved to the correct folders # TODO: transmission folder, owner should be found @@ -112,10 +96,7 @@ core/scripts/gateway @bolekk @pinebit /integration-tests/**/*automation* @smartcontractkit/keepers # CI/CD -/.github/** @chainchad @javuto @jkongie @jmank88 @samsondav -/.github/workflows/integration-tests.yml @smartcontractkit/test-tooling-team -/.github/workflows/integration-chaos-tests.yml @smartcontractkit/test-tooling-team -/.github/workflows/integration-tests-publish.yml @smartcontractkit/test-tooling-team +/.github/** @smartcontractkit/test-tooling-team /.github/workflows/performance-tests.yml @smartcontractkit/test-tooling-team /.github/workflows/automation-ondemand-tests.yml @smartcontractkit/keepers /.github/workflows/automation-benchmark-tests.yml @smartcontractkit/keepers @@ -138,9 +119,5 @@ flake.nix @smartcontractkit/prodsec-public flake.lock @smartcontractkit/prodsec-public # Config -./core/config @samsondav @jmank88 -./docs/CONFIG.md @samsondav @jmank88 @dwightjl -./internal/config/docs.toml @samsondav @jmank88 @dwightjl - -# LOOP Plugins -/plugins @jmank88 @krehermann +./docs/CONFIG.md @smartcontractkit/foundations @dwightjl +./internal/config/docs.toml @smartcontractkit/foundations @dwightjl From 7a1bb2ba8e2fad6c99fa756c7aa8bc43cf23a36a Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Thu, 25 Jan 2024 11:17:48 -0500 Subject: [PATCH 02/11] further cleanup --- CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index b186b4c7619..7b59db14f2c 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -25,7 +25,7 @@ /core/services/pg @smartcontractkit/foundations @samsondav /core/services/pipeline @smartcontractkit/foundations @smartcontractkit/integrations /core/services/synchronization @smartcontractkit/foundations -/core/services/telemetry @smartcontractkit/telemetry +/core/services/telemetry @smartcontractkit/realtime /core/services/relay/evm/mercury @smartcontractkit/mercury-team /core/services/webhook @smartcontractkit/foundations @smartcontractkit/integrations @@ -76,7 +76,7 @@ core/scripts/gateway @smartcontractkit/functions /contracts/src/v0.8/functions @smartcontractkit/functions # TODO: interfaces folder, folder should be removed and files moved to the correct folders /contracts/src/v0.8/l2ep @simsonraj -/contracts/src/v0.8/llo-feeds @austinborn @Fletch153 +/contracts/src/v0.8/llo-feeds @smartcontractkit/mercury-team # TODO: mocks folder, folder should be removed and files moved to the correct folders /contracts/src/v0.8/operatorforwarder @RensR /contracts/src/v0.8/shared @RensR From 7ed3a7b17871f7dd682133b0e6c579df6872fa4a Mon Sep 17 00:00:00 2001 From: Patrick Date: Mon, 5 Feb 2024 09:28:36 -0500 Subject: [PATCH 03/11] Update CODEOWNERS Co-authored-by: chainchad <96362174+chainchad@users.noreply.github.com> --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 7b59db14f2c..e86601b7e42 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -96,7 +96,7 @@ core/scripts/gateway @smartcontractkit/functions /integration-tests/**/*automation* @smartcontractkit/keepers # CI/CD -/.github/** @smartcontractkit/test-tooling-team +/.github/** @smartcontractkit/releng @smartcontractkit/test-tooling-team /.github/workflows/performance-tests.yml @smartcontractkit/test-tooling-team /.github/workflows/automation-ondemand-tests.yml @smartcontractkit/keepers /.github/workflows/automation-benchmark-tests.yml @smartcontractkit/keepers From 3be87fa48743f77fb67e358e9f607cab48e5fb0f Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Mon, 5 Feb 2024 09:59:35 -0500 Subject: [PATCH 04/11] further cleanup --- CODEOWNERS | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index e86601b7e42..4fb63256db6 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -10,21 +10,17 @@ /core/chains/ @smartcontractkit/integrations # Services -/core/services/cron @samsondav /core/services/directrequest @smartcontractkit/keepers /core/services/feeds @smartcontractkit/mercury-team # To be deprecated in Chainlink V3 /core/services/fluxmonitorv2 @jkongie @PiotrTrzpil @connorwstein -/core/services/health @smartcontractkit/foundations /core/services/job @smartcontractkit/ccip /core/services/keystore @smartcontractkit/keepers /core/services/ocr* @connorwstein @samsondav -/core/services/ocr2 @smartcontractkit/foundations /core/services/periodicbackup @PiotrTrzpil @samsondav /core/services/pg @smartcontractkit/foundations @samsondav /core/services/pipeline @smartcontractkit/foundations @smartcontractkit/integrations -/core/services/synchronization @smartcontractkit/foundations /core/services/telemetry @smartcontractkit/realtime /core/services/relay/evm/mercury @smartcontractkit/mercury-team /core/services/webhook @smartcontractkit/foundations @smartcontractkit/integrations @@ -62,7 +58,6 @@ core/scripts/gateway @smartcontractkit/functions # This could give some false positives, so afterwards we match on the project directories # to ensure the entire directory is always owned by the correct team. -/contracts/**/*shared* @RensR /contracts/**/*keeper* @smartcontractkit/keepers /contracts/**/*upkeep* @smartcontractkit/keepers /contracts/**/*automation* @smartcontractkit/keepers @@ -70,7 +65,6 @@ core/scripts/gateway @smartcontractkit/functions /contracts/**/*llo-feeds* @smartcontrackit/mercury-team /contracts/**/*vrf* @smartcontractkit/vrf-team /contracts/**/*l2ep* @simsonraj -/contracts/**/*operatorforwarder* @RensR /contracts/src/v0.8/automation @smartcontractkit/keepers /contracts/src/v0.8/functions @smartcontractkit/functions @@ -119,5 +113,5 @@ flake.nix @smartcontractkit/prodsec-public flake.lock @smartcontractkit/prodsec-public # Config -./docs/CONFIG.md @smartcontractkit/foundations @dwightjl -./internal/config/docs.toml @smartcontractkit/foundations @dwightjl +./docs/CONFIG.md @smartcontractkit/foundations @smartcontractkit/devrel +./internal/config/docs.toml @smartcontractkit/foundations @smartcontractkit/devrel From 1be66bfab2d17e7fe492a3ce7c922f639e1c1200 Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Mon, 5 Feb 2024 10:27:44 -0500 Subject: [PATCH 05/11] further cleanup --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 4fb63256db6..0c8a1adf1eb 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -69,7 +69,7 @@ core/scripts/gateway @smartcontractkit/functions /contracts/src/v0.8/automation @smartcontractkit/keepers /contracts/src/v0.8/functions @smartcontractkit/functions # TODO: interfaces folder, folder should be removed and files moved to the correct folders -/contracts/src/v0.8/l2ep @simsonraj +/contracts/src/v0.8/l2ep @chris-de-leon-cll /contracts/src/v0.8/llo-feeds @smartcontractkit/mercury-team # TODO: mocks folder, folder should be removed and files moved to the correct folders /contracts/src/v0.8/operatorforwarder @RensR From 856461dc40b5e367367520d400f567389f01c473 Mon Sep 17 00:00:00 2001 From: Patrick Date: Mon, 5 Feb 2024 12:37:07 -0500 Subject: [PATCH 06/11] Update CODEOWNERS Co-authored-by: Jordan Krage --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 0c8a1adf1eb..1a51789a0b7 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -72,7 +72,7 @@ core/scripts/gateway @smartcontractkit/functions /contracts/src/v0.8/l2ep @chris-de-leon-cll /contracts/src/v0.8/llo-feeds @smartcontractkit/mercury-team # TODO: mocks folder, folder should be removed and files moved to the correct folders -/contracts/src/v0.8/operatorforwarder @RensR +/contracts/src/v0.8/operatorforwarder @smartcontractkit/foundations /contracts/src/v0.8/shared @RensR # TODO: tests folder, folder should be removed and files moved to the correct folders # TODO: transmission folder, owner should be found From 129bd313177f4bdeb26f4ba372a56d36bb3e62bc Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Mon, 5 Feb 2024 12:41:58 -0500 Subject: [PATCH 07/11] further cleanup --- CODEOWNERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 1a51789a0b7..d207b8dede3 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -24,6 +24,7 @@ /core/services/telemetry @smartcontractkit/realtime /core/services/relay/evm/mercury @smartcontractkit/mercury-team /core/services/webhook @smartcontractkit/foundations @smartcontractkit/integrations +/core/services/llo @smartcontractkit/mercury-team # VRF-related services /core/services/vrf @smartcontractkit/vrf-team @@ -64,7 +65,7 @@ core/scripts/gateway @smartcontractkit/functions /contracts/**/*functions* @smartcontractkit/functions /contracts/**/*llo-feeds* @smartcontrackit/mercury-team /contracts/**/*vrf* @smartcontractkit/vrf-team -/contracts/**/*l2ep* @simsonraj +/contracts/**/*l2ep* @smartcontractkit/integrations /contracts/src/v0.8/automation @smartcontractkit/keepers /contracts/src/v0.8/functions @smartcontractkit/functions From a56b7c80946b42b5bd55e2c7794b2bf53e6f9eee Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Mon, 5 Feb 2024 12:48:11 -0500 Subject: [PATCH 08/11] further cleanup --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index d207b8dede3..780050745fd 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -11,7 +11,7 @@ # Services /core/services/directrequest @smartcontractkit/keepers -/core/services/feeds @smartcontractkit/mercury-team +/core/services/feeds @smartcontractkit/FMS # To be deprecated in Chainlink V3 /core/services/fluxmonitorv2 @jkongie @PiotrTrzpil @connorwstein From 787aabe5a5e0417fc2d16dcce600300026312e37 Mon Sep 17 00:00:00 2001 From: Patrick Date: Mon, 5 Feb 2024 17:19:17 -0500 Subject: [PATCH 09/11] Update CODEOWNERS Co-authored-by: Jordan Krage --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 780050745fd..421de4cb6ec 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -14,7 +14,7 @@ /core/services/feeds @smartcontractkit/FMS # To be deprecated in Chainlink V3 -/core/services/fluxmonitorv2 @jkongie @PiotrTrzpil @connorwstein +/core/services/fluxmonitorv2 @smartcontractkit/foundations /core/services/job @smartcontractkit/ccip /core/services/keystore @smartcontractkit/keepers /core/services/ocr* @connorwstein @samsondav From ba7b69ff4772bc4702528d923e3f181e0947d512 Mon Sep 17 00:00:00 2001 From: Patrick Date: Mon, 5 Feb 2024 17:19:32 -0500 Subject: [PATCH 10/11] Update CODEOWNERS Co-authored-by: Jordan Krage --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 421de4cb6ec..75ae218c83b 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -17,7 +17,7 @@ /core/services/fluxmonitorv2 @smartcontractkit/foundations /core/services/job @smartcontractkit/ccip /core/services/keystore @smartcontractkit/keepers -/core/services/ocr* @connorwstein @samsondav +/core/services/ocr* @smartcontractkit/foundations /core/services/periodicbackup @PiotrTrzpil @samsondav /core/services/pg @smartcontractkit/foundations @samsondav /core/services/pipeline @smartcontractkit/foundations @smartcontractkit/integrations From 0fbd2a645c4a45c79353d092e200c1b89996a1c1 Mon Sep 17 00:00:00 2001 From: Patrick Date: Mon, 5 Feb 2024 17:19:42 -0500 Subject: [PATCH 11/11] Update CODEOWNERS Co-authored-by: Jordan Krage --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 75ae218c83b..74a7208cc0a 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -18,7 +18,7 @@ /core/services/job @smartcontractkit/ccip /core/services/keystore @smartcontractkit/keepers /core/services/ocr* @smartcontractkit/foundations -/core/services/periodicbackup @PiotrTrzpil @samsondav +/core/services/periodicbackup @smartcontractkit/foundations /core/services/pg @smartcontractkit/foundations @samsondav /core/services/pipeline @smartcontractkit/foundations @smartcontractkit/integrations /core/services/telemetry @smartcontractkit/realtime