From ba27d7630e2a45edb137ba50b1841d8b14002b12 Mon Sep 17 00:00:00 2001 From: george-dorin Date: Fri, 10 Nov 2023 14:40:05 +0200 Subject: [PATCH] Add comment explaining why the code lives inside the newServicesGenericPlugin method --- core/services/ocr2/delegate.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/services/ocr2/delegate.go b/core/services/ocr2/delegate.go index a280fb10e3f..f808bb83c42 100644 --- a/core/services/ocr2/delegate.go +++ b/core/services/ocr2/delegate.go @@ -595,6 +595,8 @@ func (d *Delegate) newServicesGenericPlugin( if ok { providerClientConn = providerConn.ClientConn() } else { + //We chose to deal with the difference between a LOOP provider and an embedded provider here rather than in NewServerAdapter because this has a smaller blast radius, as the scope of this workaround is to enable the medianpoc for EVM and not touch the other providers. + //TODO: remove this workaround when the EVM relayer is running inside of an LOOPP d.lggr.Info("provider is not a LOOPP provider, switching to provider server") ps, err := relay.NewProviderServer(provider, types.OCR2PluginType(cconf.ProviderType), d.lggr)