From 9ca100d8f50d1f0c76362d45f2c330e4f048cce5 Mon Sep 17 00:00:00 2001
From: Emre Sonmez <esonmez@users.noreply.github.com>
Date: Wed, 3 Oct 2018 17:13:51 -0700
Subject: [PATCH] feat(mode): add ability to override testMode in getAuthUrl
 (#64)

* feat(mode): add ability to override testMode in getAuthUrl

* Add comments.
---
 .gitignore                   |  3 ++
 lib/auth-client.js           | 10 ++++++-
 test/unit/lib/auth-client.js | 58 ++++++++++++++++++++++++++++++++++++
 3 files changed, 70 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index cd25b7ff..8d245773 100644
--- a/.gitignore
+++ b/.gitignore
@@ -35,6 +35,9 @@ Session.vim
 [._]s[a-w][a-z]
 [._]*.]s[a-w][a-z]]
 
+## Webstorm
+.idea
+
 ## Sublime
 *.tmlanguage.cache
 *.tmPreferences.cache
diff --git a/lib/auth-client.js b/lib/auth-client.js
index 2293548b..761032a7 100644
--- a/lib/auth-client.js
+++ b/lib/auth-client.js
@@ -114,6 +114,8 @@ function AuthClient(options) {
  * `true` will show the permissions approval screen on every authentication
  * attempt, even if the user has previously consented to the exact scope of
  * permissions.
+ * @param {Boolean} [options.testMode=false] - Launch the Smartcar auth flow in
+ * test mode.
  * @return {String} OAuth authorization URL to direct user to.
  * @example
  * https://connect.smartcar.com/oauth/authorize?
@@ -146,11 +148,17 @@ AuthClient.prototype.getAuthUrl = function(options) {
   }
 
   let mode;
-  if (this.development !== undefined) {
+  if (options.testMode !== undefined) {
+    // Override mode with testMode option.
+    mode = options.testMode;
+  } else if (this.development !== undefined) {
+    // Use deprecated 'development' flag.
     mode = this.development;
   } else {
+    // Use 'testMode' flag.
     mode = this.testMode;
   }
+
   parameters.mode = mode ? 'test' : 'live';
 
   const query = qs.stringify(parameters);
diff --git a/test/unit/lib/auth-client.js b/test/unit/lib/auth-client.js
index 466bfc27..0baa2b06 100644
--- a/test/unit/lib/auth-client.js
+++ b/test/unit/lib/auth-client.js
@@ -212,6 +212,64 @@ test('getAuthUrl - test mode false', function(t) {
 
 });
 
+test('getAuthUrl - test mode overrides constructor testMode value - true', function(t) {
+
+  const client = new AuthClient({
+    clientId: CLIENT_ID,
+    clientSecret: CLIENT_SECRET,
+    redirectUri: 'https://insurance.co/callback',
+    scope: ['read_odometer', 'read_vehicle_info'],
+    testMode: true,
+  });
+
+  const actual = client.getAuthUrl({
+    scope: 'this should be ignored',
+    state: 'fakestate',
+    forcePrompt: true,
+    testMode: false,
+  });
+
+  let expected = 'https://connect.smartcar.com/oauth/authorize?';
+  expected += `response_type=code&client_id=${CLIENT_ID}`;
+  expected += '&redirect_uri=https%3A%2F%2Finsurance.co%2Fcallback';
+  expected += '&approval_prompt=force';
+  expected += '&scope=read_odometer%20read_vehicle_info';
+  expected += '&state=fakestate';
+  expected += '&mode=live';
+
+  t.is(actual, expected);
+
+});
+
+test('getAuthUrl - test mode overrides constructor testMode value - false', function(t) {
+
+  const client = new AuthClient({
+    clientId: CLIENT_ID,
+    clientSecret: CLIENT_SECRET,
+    redirectUri: 'https://insurance.co/callback',
+    scope: ['read_odometer', 'read_vehicle_info'],
+    testMode: false,
+  });
+
+  const actual = client.getAuthUrl({
+    scope: 'this should be ignored',
+    state: 'fakestate',
+    forcePrompt: true,
+    testMode: true,
+  });
+
+  let expected = 'https://connect.smartcar.com/oauth/authorize?';
+  expected += `response_type=code&client_id=${CLIENT_ID}`;
+  expected += '&redirect_uri=https%3A%2F%2Finsurance.co%2Fcallback';
+  expected += '&approval_prompt=force';
+  expected += '&scope=read_odometer%20read_vehicle_info';
+  expected += '&state=fakestate';
+  expected += '&mode=test';
+
+  t.is(actual, expected);
+
+});
+
 test('getAuthUrl - deprecated development mode', function(t) {
 
   const client = new AuthClient({