Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent all build dependencies from being packaged into a fat jar #150

Closed
wants to merge 1 commit into from

Conversation

davismariotti
Copy link

Description

It isn't necessary to package all dependencies into a large "fat" jar. This change will remove all transitive dependencies from the final jar, and improve compatibility with other projects that might be operating with different versions of the same dependencies.

Fixes #107 and #139

@davismariotti
Copy link
Author

Any updates on this?

@Anth06ny
Copy link

I have the same problème with Okhttp

@s-ashwinkumar
Copy link
Member

Apologies. This slipped out of our radar. Our CI currently doesn't get triggered due to lack of access to secrets to run the tests.
I have recreated the PR and will test and merge it in. Once its merged in, i will comment here and close this one.

@s-ashwinkumar
Copy link
Member

This, was merged in #151 , one of the owners had to recreate the PR because tests currently depend on a token that requires one of the owners. Closing this in favor of #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Embed dependencies brake Kotlin projects compilation
3 participants