Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print extensions and modifierExtensions before stripping them #346

Open
mikix opened this issue Sep 9, 2024 · 2 comments · May be fixed by #347
Open

Print extensions and modifierExtensions before stripping them #346

mikix opened this issue Sep 9, 2024 · 2 comments · May be fixed by #347
Assignees

Comments

@mikix
Copy link
Contributor

mikix commented Sep 9, 2024

This way a user can still get a sense of what extensions are in use / what they are missing. And then they can investigate further / submit a ticket for support for the extension as needed.

Maybe just print a number of resources with the extension, like so:

  25 Patients had extension: https://example.com/new-thing
@mikix mikix self-assigned this Sep 9, 2024
@mikix
Copy link
Contributor Author

mikix commented Sep 9, 2024

Or... maybe in the case of extensions, it's better to leave them in place, but remove all content. So they just have the url field. That way we can always inspect their presence via SQL after the fact.

Unknown modifierExtensions do currently get printed to the console, one per line. So it's a little noisy. But workable for now.

So maybe an MVP of this ticket is: "stop erasing extensions entirely, just erase their content, leave the url in place"

@mikix mikix linked a pull request Sep 10, 2024 that will close this issue
2 tasks
@mikix
Copy link
Contributor Author

mikix commented Sep 10, 2024

Jamie was nervous enough about including even a whiff of arbitrary extensions (and the more complicated de-id story of "well, we mostly strip extensions", that current thinking is to go back to just logging these on the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant