-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SCEP Polling #1502
base: master
Are you sure you want to change the base?
Support for SCEP Polling #1502
Conversation
Adrian Alexander seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hey @adrian-alexander, Thank you for this contribution. I'll have a look at it. We'll also discuss it in our next open source triage meeting. Do you have a specific use case for which you need |
Hey @hslatman, My team has been looking for a CA with SCEP polling to replace our in-house CA. Our use case is untrusted networks and deployments. We need an admin to manually approve cert requests from technicians at the sites. |
Sounds like a legit use case 🙂 I haven't looked into the code in detail yet, but from a quick skim I don't see changes to how the Since you referred to #1170, I guess you're aware of the fact that we have support for (manual) approval workflows in our product. Ideally the flow you contributed here would have to be interoperable with that part of our stack. Besides that, it might be an option to provide another method. One way could be to make it work with webhooks. Are you open to talk more about your use case with a colleague of mine? |
For testing, I used
I'm actually part of the same team as the guy in #1170 . What he discussed in his meeting with you is the same thing as my use case 😃 |
Description:
This pull request adds SCEP polling mode which can be configured via ca.json. When enabled, the CA will return a PENDING response which will cause the client to poll the CA server. Fixes #1170 .
Two new databases have been created named
x509_csr
andx509_certs_csr
to save the certificate requests that have been signed.