Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg minimum version check for error handling for VAD failures #196

Open
aaronrudkin opened this issue Oct 27, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@aaronrudkin
Copy link

aaronrudkin commented Oct 27, 2024

I did an OS upgrade on my Synology NAS. This overrode something in my path settings such that ffmpeg4, rather than ffmpeg7, was the default binary aliased to ffmpeg. That's not your problem, and I got it solved. But until I did, every attempt to use ffmpeg gave me this error

if len(media_bstring) == 0:
raise ValueError(
"Unable to detect speech. "
"Perhaps try specifying a different stream / track, or a different vad."
)

The error is a reasonable one in hindsight, but it took me a while to figure out that the problem was actually downstream with the ffmpeg binary, not ffsubsync.

My sense is that if there's a minimum ffmpeg version that supports the VAD stuff, then it'd probably be good to either, in advance of running the script or in response to this error, verifying that the ffmpeg binary meets the minimum version requirement. I'd probably insert the check into the ffmpeg_bin_path function here

def ffmpeg_bin_path(bin_name, gui_mode, ffmpeg_resources_path=None):

Thanks. ffsubsync is great!

@aaronrudkin aaronrudkin added the bug Something isn't working label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant