-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top-level reading order #23
Open
bertsky
wants to merge
15
commits into
slub:master
Choose a base branch
from
bertsky:toplevel-reading-order
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+91,095
−11,666
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1175ba2 - Browse repository at this point
Copy the full SHA 1175ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93d766c - Browse repository at this point
Copy the full SHA 93d766cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e7248 - Browse repository at this point
Copy the full SHA 23e7248View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5be42bb - Browse repository at this point
Copy the full SHA 5be42bbView commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4111b3a - Browse repository at this point
Copy the full SHA 4111b3aView commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9aec1e0 - Browse repository at this point
Copy the full SHA 9aec1e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f456777 - Browse repository at this point
Copy the full SHA f456777View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f22fdb - Browse repository at this point
Copy the full SHA 3f22fdbView commit details -
dangling lines/words: construct dummy regions/lines earlier, copy som…
…e attributes (but not @Custom); ensure readingorder idrefs are correct (also for dummy text and image region)
Configuration menu - View commit details
-
Copy full SHA for 2f2366e - Browse repository at this point
Copy the full SHA 2f2366eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72e9e1d - Browse repository at this point
Copy the full SHA 72e9e1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cddb067 - Browse repository at this point
Copy the full SHA cddb067View commit details
Commits on Aug 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5424b05 - Browse repository at this point
Copy the full SHA 5424b05View commit details
Commits on Aug 21, 2024
-
handle truly recursive regions…
- `TextractLayout`: init with additional list of top-level block dict stored in `child_regions`: - just ID→dict (for LAYOUT_ types during build) - or ID→block (for TextractTable, KEY, SELECTION etc. already instantiated) - add `parent_layout` reference - `TextractTable`: add `parent_layout` reference - `TextractKey`: add `parent_layout` reference - `TextractValue`: add `parent_layout` reference - build `layouts` after all other blocks are built - replace recursive `child_regions` / `parent_layout` after all `layouts` are built; remove recursive instances from top level to avoid duplication in ReadingOrder or PcGts instantiation - ReadingOrder: extend recursive case (OrderedGroup) of `LAYOUT_FIGURE` with `LINE` children to `LAYOUT_*` with any `child_regions` - instantiation of PcGts types for `layouts` and `tables`: refactor as (inline) function for recursion and - try to re-use code - add assertions around known types of recursion (to be revisited with better documentation from AWS or more data examples)
Configuration menu - View commit details
-
Copy full SHA for 86df1be - Browse repository at this point
Copy the full SHA 86df1beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18b6fd1 - Browse repository at this point
Copy the full SHA 18b6fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eb96ab - Browse repository at this point
Copy the full SHA 4eb96abView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.