Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Subfile::get_frame_into to use utils::merge_frames #68

Open
Bechir-Brahem opened this issue May 7, 2024 · 0 comments
Open

Comments

@Bechir-Brahem
Copy link

Bechir-Brahem commented May 7, 2024

network_io and file_io both require the same functionality of merging frames according to a specific geometry.

we should use the merge_frames function (in utils) for both network_io and file_io. this improves testability and avoid redundancy in a very error prone functionality.

currently only network_io uses this function (#65)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant