Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctrine/annotations is needed #20

Closed
devbysb opened this issue Oct 16, 2023 · 3 comments · Fixed by #22
Closed

doctrine/annotations is needed #20

devbysb opened this issue Oct 16, 2023 · 3 comments · Fixed by #22

Comments

@devbysb
Copy link

devbysb commented Oct 16, 2023

Hi, with php8 normally we don't need doctrine/annotations have you plane to remove this dependency ? (in v2)
@devbysb
Copy link
Author

devbysb commented Dec 4, 2023

Hi, If I disable annotations to resolve all symfony 6.4 deprecations with this

in the framework.yml file
annotations: false

The breadcrumb not working

The service "slope_it.breadcrumb.listener" has a dependency on a non-existent service "annotation_reader".

Is an update is planned ?

@asprega
Copy link
Contributor

asprega commented Dec 11, 2023

Hi! Sorry for the late reply. Yes, I'm planning to remove support for annotations altogether. I will update this issue once completed (hopefully by the end of the year). Thanks!

@asprega asprega linked a pull request Dec 21, 2023 that will close this issue
Bump to min PHP 8 and Symfony 5.4, drop doctrine/annotations dependency. #22
Merged
@asprega
Copy link
Contributor

asprega commented Dec 21, 2023 •
edited
Loading

This was released as part of 2.0.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump to min PHP 8 and Symfony 5.4, drop doctrine/annotations dependency. slope-it/breadcrumb-bundle
2 participants
@asprega @devbysb