Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slog does not honor #[track_caller] #342

Open
ppershing opened this issue Oct 8, 2024 · 0 comments
Open

Slog does not honor #[track_caller] #342

ppershing opened this issue Oct 8, 2024 · 0 comments

Comments

@ppershing
Copy link

Internally, slog uses file!() macro and its friends. This unfortunately does not work as expected if user opts in to #[track_caller] directive.

As a reference log crate fixed this in https://github.com/rust-lang/log/pull/633/files (with discussion starting back in rust-lang/log#410)

I can try to create an MR working in similar ways as the abovementioned MR on log if you are interested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppershing