Replies: 1 comment 1 reply
-
Can you also add a note about |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is quite bigger than I anticipated when started this. Originally was supposed to be a small update to make
TimeProbeSeismic.jl
easier to overload.Optimization
#43
Removed
SLIM_Optim
that got moved to SlimOptim.jljudiJacobian
This is now reworked as an abstract type
judiAbstractJacobian
that makes "inheritance" easier. Now both judiJacobian and judiJacobianExtQ are subtypes of it make it a lot of duplicate code disappear. Absolutely nothing changed on the user side so you don't need to care about it.typed implementation
I added and now enforce typed arguments for functions. It makes most of the codebase more juliaesque and therefore a tiny bit more efficient since it allows better dispatch on types. Once again nothing should have changed from the user perspective as there are still fallback definitions for input with not expected types.
Parallelization
Switched the parallelization to
pmap
that makes it quite cleaner and added fallback cases for single source and/or serial julia to avoid thepmap
overhead in these cases. In serial mode, it now usesasyncmap
that may still have multiple tasks running at once.Misc
Few small fixes and updates:
limit_m
that seemed to have a shift somewhere and wasn't matching the data exactly. Fixes limit_m issue #55__init__
so that it is only loaded once and just used when needed.Types
(judiVector, judiWeigths, ...),Modeling
(modeling function such as fwi_objectiv),LinearOperators
andUtils
.Types
.return_array
withdm=0
Invertibe network fixes #51cumsum
Overload cumsum and diff functions for judiVector #47 Fix implementation of cumsum and diff function on judiVector to be dimensional #50@ziyiyin97 This should fix your
limit_m
issues as well including your PR #54This discussion was created from the release Internal updates and cleanup.
Beta Was this translation helpful? Give feedback.
All reactions