Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language strings aka. load_textdomain #30

Open
quatroweb opened this issue Mar 4, 2014 · 3 comments
Open

Language strings aka. load_textdomain #30

quatroweb opened this issue Mar 4, 2014 · 3 comments

Comments

@quatroweb
Copy link

I noticed that the theme are using load_textdomain in stead of load_theme_textdomain

Is that something you have takken into concideration?

I got curious and actually counted the textdomains in the strings. I found about 10-11 different domains. Do you have plans to decrease these to just one or few to have a better overview of the language strings?

@quatroweb
Copy link
Author

What are your thoughts about the subject?

I tried to translate some few strings in the theme, but doesn't seem to work.

On the todo 1.0 list you wrote following:

  • Look in to combining functions.php/brew.php/bones.php

Are you planning to also clean up the language strings?

I also found more info here:
http://codex.wordpress.org/Translating_WordPress

And here:
https://codex.wordpress.org/I18n_for_WordPress_Developers

@slightlyoffbeat
Copy link
Owner

I need to look in to this. All of the language strings are there as a result of me using Bones.

To be honest, I was considering pulling the code for the translation strings as I'll likely never use it in any project. If there's enough interest I can try and keep it/clean it up.

Looking around the bugs and messgaes on the Bones repository, it would appear that the translation files are incomplete and not completely understood by the author:

eddiemachado-zz/bones#400

eddiemachado-zz/bones#10

@quatroweb
Copy link
Author

I see what you mean.

In my opinion this really seems to be a good Bootstrap theme. I'm really interested in getting it to work properly for the language strings.

When or if you have in plans to do so, I will personally get the Portuguese (pt_BR) translation 100% done and send you the files to include them in your theme.

Could be a start though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants