-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language strings aka. load_textdomain #30
Comments
What are your thoughts about the subject? I tried to translate some few strings in the theme, but doesn't seem to work. On the todo 1.0 list you wrote following:
Are you planning to also clean up the language strings? I also found more info here: And here: |
I need to look in to this. All of the language strings are there as a result of me using Bones. To be honest, I was considering pulling the code for the translation strings as I'll likely never use it in any project. If there's enough interest I can try and keep it/clean it up. Looking around the bugs and messgaes on the Bones repository, it would appear that the translation files are incomplete and not completely understood by the author: |
I see what you mean. In my opinion this really seems to be a good Bootstrap theme. I'm really interested in getting it to work properly for the language strings. When or if you have in plans to do so, I will personally get the Portuguese (pt_BR) translation 100% done and send you the files to include them in your theme. Could be a start though. |
I noticed that the theme are using load_textdomain in stead of load_theme_textdomain
Is that something you have takken into concideration?
I got curious and actually counted the textdomains in the strings. I found about 10-11 different domains. Do you have plans to decrease these to just one or few to have a better overview of the language strings?
The text was updated successfully, but these errors were encountered: