Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in React #368

Open
pdl opened this issue Nov 20, 2016 · 1 comment
Open

Rewrite in React #368

pdl opened this issue Nov 20, 2016 · 1 comment
Labels
enhancement

Comments

@pdl
Copy link
Contributor

pdl commented Nov 20, 2016

From #361:

most of slap's active development has been centered around porting to react-blessed. That means that there is a small but non-trivial chance that some of the functionality you are working on may be changed or lost once the react-blessed changes are merged. Here's the active branch in slap: dbkaplun/slap#react-blessed. While editor-widget has been ported completely and works very well, slap itself is missing some key pieces (most importantly panes).
@pdl
Copy link
Contributor Author

pdl commented Nov 20, 2016

When trying this out, I appear to be running into (this issue)[https://github.com/npm/npm/issues/5875] with npm link. Commenting out line 158 (setState in newPane) means I get something but there's clearly something up. @dbkaplun do you have a functioning workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdl @dbkaplun