Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Lint] Forbid using implicit internal APIs #72

Open
ZacSweers opened this issue May 28, 2023 · 0 comments
Open

[New Lint] Forbid using implicit internal APIs #72

ZacSweers opened this issue May 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ZacSweers
Copy link
Collaborator

Some libraries use **.internal.** packages to share APIs across artifacts. Let's expand either the denylisted API checker or the restrictcallsto checker to do this check, or possibly make a new one if needed.

Checking this would be easy - it would be an API in a package that contains .internal. and is a PsiCompiledElement (which would indicate that the element is from an external library). Note this wouldn't work for checkDependencies=true though, so something else would need to be in place for that. Maybe if the package doesn't share a common prefix (i.e. com.library.) with the calling package?

@ZacSweers ZacSweers added the enhancement New feature or request label May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant