ci: add windows testing to CI by lifting OS into its own test matrix … #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
- Coverage 91.83% 91.83% -0.01%
==========================================
Files 38 38
Lines 10264 10263 -1
Branches 646 646
==========================================
- Hits 9426 9425 -1
Misses 826 826
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
…enting user agent
…ndows, since Windows does not support this option.
filmaj
commented
Oct 31, 2024
| waitForOutputSpy.rejects(); | ||
| await assert.rejects(platform.runStop({ proc: fakeProcess, waitForShutdown: true })); | ||
| it('non-Windows only: should reject if waitForShutdown=true and waitForOutput rejects', async () => { | ||
| if (process.platform !== 'win32') { |
There was a problem hiding this comment.
The reason we don't run this test on Windows is that this code-under-test also doesn't run on Windows
filmaj
commented
Oct 31, 2024
| assert.equal(error.code, ErrorCode.RequestError); | ||
| assert.equal(error.original.config.timeout, timeoutOverride); | ||
| assert.equal(error.original.isAxiosError, true); | ||
| assert.instanceOf(error, Error); | ||
| assert.isTrue((logger.warn as sinon.SinonStub).calledOnce, 'expected Logger to be called once'); |
There was a problem hiding this comment.
Moved this assert down, as it flaked a few times on Windows in CI.. next time it does, I want to make sure these other assertions about the state of the error execute.
mwbrooks
approved these changes
Oct 31, 2024
Comment on lines
+466
to
+468
| // User Agent value is different across platforms. | ||
| // on mac this is: @slack:web-api/7.7.0 node/18.15.0 darwin/23.6.0 | ||
| // on windows this is: @slack:web-api/7.7.0 cmd.exe /22.10.0 win32/10.0.20348 |
There was a problem hiding this comment.
Thanks for the detailed documentation. These kinda of notes help future maintainers a lot!
Co-authored-by: Michael Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-apineeds changing, asprocess.titlecan return a wide variety of results, including it can be completely overridden!cli-testfunctionality is skipped on Windows (graceful shutting down of processes / lack of interrupt signal support on Windows), so the relevant test executing this branch of code also needs to be skipped on windows.