-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 9+ Modularity Supports #198
Comments
Thank you for your feedback. Honestly, I'm not familiar with making libraries compatible with Java modules yet but I'd love to make jslack modules-ready. Could you help me? |
I revisited this issue a little bit but let me hold working on this. I would like to continue supporting Java 8 for a while. |
@seratch I'd be happy to submit a pull request to fix this, while still maintaining Java 8 compatibility. |
That is really needed thing, we unable to use in the project |
Tricky thing to make slack API compatible with Java Module system:
|
Tricky thing to make slack API compatible with Java Module system: <groupId>com.xxx.yyy</groupId>
<artifactId>slack-spring-boot-starter</artifactId>
<version>0.0.1</version>
<packaging>jar</packaging>
<name>slack-spring-boot-starter</name>
<description>slack-spring-boot-starter</description>
<properties>
<java.version>21</java.version>
<slack.api.client.version>1.43.1</slack.api.client.version>
</properties>
<dependencies>
<dependency>
<groupId>com.slack.api</groupId>
<artifactId>slack-api-client</artifactId>
<version>${slack.api.client.version}</version>
<exclusions>
<exclusion>
<groupId>com.slack.api</groupId>
<artifactId>slack-api-model</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.slack.api</groupId>
<artifactId>slack-api-model</artifactId>
<version>${slack.api.client.version}</version>
</dependency>
...
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.6.0</version>
<executions>
<execution>
<goals>
<goal>shade</goal>
</goals>
<phase>package</phase>
<configuration>
<artifactSet>
<includes>
<include>com.slack.api:slack-api-client</include>
<include>com.slack.api:slack-api-model</include>
</includes>
</artifactSet>
<filters>
<filter>
<artifact>*:*</artifact>
<excludes>
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
</excludes>
</filter>
</filters>
</configuration>
</execution>
</executions>
</plugin> your project POM.xml: <dependency>
<groupId>com.slack.api</groupId>
<artifactId>slack-api-client</artifactId>
<version>1.43.1</version>
</dependency>
replace to:
<dependency>
<groupId>com.xxx.yyy</groupId>
<artifactId>slack-spring-boot-starter</artifactId>
<version>0.0.1</version>
</dependency> |
trying out a simple slack API within a module, but seeing this problem
it doesn't seem like jslack was ever adjusted to work with Project Jigsaw (java 9 modules).
The text was updated successfully, but these errors were encountered: