Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AwsCredentialsProvider to AmazonS3InstallationService #1418

Closed
1 of 6 tasks
bruceadowns opened this issue Jan 13, 2025 · 1 comment · Fixed by #1419
Closed
1 of 6 tasks

Expose AwsCredentialsProvider to AmazonS3InstallationService #1418

bruceadowns opened this issue Jan 13, 2025 · 1 comment · Fixed by #1419
Labels
enhancement M-T: A feature request for new functionality project:bolt
Milestone

Comments

@bruceadowns
Copy link

I would like to extend AmazonS3InstallationService to provide a custom AwsCredentialsProvider.
This picks off where #1165 left off.
Same change will apply to AmazonS3OAuthStateService.

Proposed constructor:

    public AmazonS3InstallationService(String bucketName,
        AwsCredentialsProvider credentialsProvider,
        String region,
        String endpointUrl)

This accommodates a custom (i.e. spring) provider and allows for endpoint override to support DR scenarios and https:/localstack.cloud.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. 🙇

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch
Copy link
Member

seratch commented Jan 14, 2025

Thanks for the suggestion; your suggestion here makes sense. I've submitted a pull request adding a new contructor: #1419

seratch added a commit to seratch/java-slack-sdk that referenced this issue Jan 14, 2025
seratch added a commit to seratch/java-slack-sdk that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants