Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file upload v2 #531

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

file upload v2 #531

wants to merge 4 commits into from

Conversation

monkeyWzr
Copy link

Resolves #514

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12794429066

Details

  • 20 of 33 (60.61%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.16%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/files.rb 1 14 7.14%
Totals Coverage Status
Change from base Build 12777347391: -0.2%
Covered Lines: 5404
Relevant Lines: 6061
💛 - Coveralls

dblock
dblock requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

The lib/slack/web/api/endpoints/files.rb is a generated file, so that's probably not where that code should go. The implementation also needs tests, please.

Could you please explain the accept charset changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove files.upload in favor of files.getUploadURLExternal, etc.
3 participants
@monkeyWzr @coveralls @dblock