-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support buildkite CICD and restructure smoke tests #4396
base: master
Are you sure you want to change the base?
Support buildkite CICD and restructure smoke tests #4396
Conversation
exclude: (build/.*|sky/skylet/providers/ibm/.*) # Matches exclusions from the script | ||
args: ['--recursive', '--parallel'] # Only necessary flags | ||
exclude: (sky/skylet/providers/ibm/.*) # Matches exclusions from the script | ||
args: ['--recursive', '--parallel', '--in-place'] # Only necessary flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't add this flag, pre-commit
does nothing for yapf. Now it should be fine.
(sky) ➜ skypilot git:(dev/zeping/restructure_smoke_tests) ✗ git commit -m "fix pre-commit"
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
black (IBM specific).................................(no files to check)Skipped
isort (general)......................................(no files to check)Skipped
isort (IBM specific).................................(no files to check)Skipped
mypy.....................................................................Passed
yapf.....................................................................Failed
- hook id: yapf
- files were modified by this hook
pylint...............................................(no files to check)Skipped
@@ -24,7 +24,6 @@ repos: | |||
args: | |||
- "--sg=build/**" # Matches "${ISORT_YAPF_EXCLUDES[@]}" | |||
- "--sg=sky/skylet/providers/ibm/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format.sh
script limits files to this range, but .github/workflows/format.yml does not. Remove the limitation in format.sh to ensure consistency with the final result (format.yml).
The PR is based on #4386. Please review and merge that PR first, then review and merge this one.test_smoke.py
into multiple files within this directory..buildkite
to contain all the smoke tests that will be picked up by buildkite..buildkite
correspond one-to-one with files undertests/smoke_tests
.test_required_before_merge.py
will be triggered only by valid users' comment on a PR.pre-merge-test aws
/pre-merge-test aws,azure
/pre-merge-test
(default aws)python .buildkite/generate_pipeline.py
to generate all the YAML files fromtests/smoke_tests
. (This process can be automated and will be implemented in a subsequent PR.)LOG_TO_STDOUT
environment variable when executing pytest, so that the output is visible directly on the CI/CD terminal pageTest
Don't have permission for this repo, currently tested under my personal repo
Per PR merged CI
Scheduled CI
A build attempt link
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh