Move systemd code to linux-only built files #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanatic can you install this on windows? I always get error when install on windows (the problem is about systemd) |
|
Yeah, this change disables the systemd activation code when built on Windows - but there are some other code that assumes Linux (like reading from |
|
@fanatic thanks, but i still can not install skydns. I think some other part code may also use the package "systemd". I don't know how to fixed that. |
|
@JaysLiang i has tested to compile @fanatic code on windows without error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves systemd activation to a build tagged file to allow skydns to be built on Windows. For issue #212