Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at a stubzones bugfix #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdima
Copy link

@kdima kdima commented Dec 29, 2016

This PR addresses the following issue.
Say you have 2 stubzones registered in etcd the following way:

/skydns/com/test/dns/stub/com/othertest/a/stubzone1/a    1.1.1.1
/skydns/com/test/dns/stub/com/othertest/a/stubzone1/b    1.1.1.2
/skydns/com/test/dns/stub/com/othertest/stubzone2/b       1.1.1.1
/skydns/com/test/dns/stub/com/othertest/stubzone2/a       1.1.1.2

Current implementation will consider these records duplicate and one of the stubzones will not be available.

To avoid this when we are looking up stubzone records we keep track of the subdomain in this case stubzone1.a.othertest.com and stubzone2.othertest.com and dedup records only inside the same subdomian.

I am not sure if this should be behind the flag stub or this can work as a general implementation.

@kdima
Copy link
Author

kdima commented Dec 29, 2016

This is the first pass if the implementation looks reasonable I will add same logics to etcd3 backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant