Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll position changing while reloading content on capsule with expired certificate #666

Open
acidus99 opened this issue May 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@acidus99
Copy link

This is a bit of an odd minor bug. When you click "refresh" on a page that is served from a capsule with an expired certificate, the page scrolls up by a pixel:

Screen.Recording.2024-05-12.at.12.28.47.PM.mov

This behavior doesn't happen on capsules with unexpired certs. Perhaps this is related to the "expired certificate" banner that is displayed at the top of the content?

@skyjake
Copy link
Owner

skyjake commented May 21, 2024

You are probably right. The scroll position is saved as a normalized offset, and one of those calculations must be using the document height excluding the banner.

@skyjake skyjake added the bug Something isn't working label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants