Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teardown of an AMQP session with active links and deliveries causes a router crash #1698

Closed
kgiusti opened this issue Dec 12, 2024 · 0 comments · Fixed by #1699
Closed

Teardown of an AMQP session with active links and deliveries causes a router crash #1698

kgiusti opened this issue Dec 12, 2024 · 0 comments · Fixed by #1699
Assignees
@kgiusti

Comments

@kgiusti
Copy link
Contributor

kgiusti commented Dec 12, 2024 •
edited
Loading 

=================================================================
==258021==ERROR: AddressSanitizer: use-after-poison on address 0x5130000ed4a0 at pc 0x000000478562 bp 0x7ff47adabe60 sp 0x7ff47adabe58
WRITE of size 8 at 0x5130000ed4a0 thread T5
    #0 0x478561 in qd_container_handle_event /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/container.c:564
    #1 0x49a426 in qd_connection_handle_event /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/qd_connection.c:828
    #2 0x6a8cf2 in proactor_thread /home/kgiusti/tmp/skupper-router/src/server.c:172
    #3 0x551579 in _thread_init /home/kgiusti/tmp/skupper-router/src/posix/threading.c:207
    #4 0x7ff49185df95 in asan_thread_start(void*) (/lib64/libasan.so.8+0x5df95) (BuildId: a4ad7eb954b390cf00f07fa10952988a41d9fc7a)
    #5 0x7ff4908a66d6 in start_thread (/lib64/libc.so.6+0x976d6) (BuildId: 77c77fee058b19c6f001cf2cb0371ce3b8341211)
    #6 0x7ff49092a60b in __clone3 (/lib64/libc.so.6+0x11b60b) (BuildId: 77c77fee058b19c6f001cf2cb0371ce3b8341211)

0x5130000ed4a0 is located 160 bytes inside of 320-byte region [0x5130000ed400,0x5130000ed540)
allocated by thread T5 here:
    #0 0x7ff4918f6f8d in posix_memalign (/lib64/libasan.so.8+0xf6f8d) (BuildId: a4ad7eb954b390cf00f07fa10952988a41d9fc7a)
    #1 0x4c57fc in qd_alloc /home/kgiusti/tmp/skupper-router/src/alloc_pool.c:343
    #2 0x471f8a in new_qd_link_t /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/container.c:63
    #3 0x472e4f in setup_incoming_link /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/container.c:182
    #4 0x47950d in qd_container_handle_event /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/container.c:604
    #5 0x49a426 in qd_connection_handle_event /home/kgiusti/tmp/skupper-router/src/adaptors/amqp/qd_connection.c:828
    #6 0x6a8cf2 in proactor_thread /home/kgiusti/tmp/skupper-router/src/server.c:172
    #7 0x551579 in _thread_init /home/kgiusti/tmp/skupper-router/src/posix/threading.c:207
    #8 0x7ff49185df95 in asan_thread_start(void*) (/lib64/libasan.so.8+0x5df95) (BuildId: a4ad7eb954b390cf00f07fa10952988a41d9fc7a)
@kgiusti kgiusti self-assigned this Dec 12, 2024
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Dec 13, 2024
@kgiusti
Fixes skupperproject#1698: prevent use-after-free of qd_link_t on ses…
ba7af25 
…sion close

Previously the detach handler might free the qd_link_t but it was not
consistent. This patch moves the qd_link_t cleanup to the container.
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Dec 13, 2024
@kgiusti
Fixes skupperproject#1698: prevent use-after-free of qd_link_t on ses…
ae802ce 
…sion close

Previously the detach handler might free the qd_link_t but it was not
consistent. This patch moves the qd_link_t cleanup to the container.
@kgiusti kgiusti linked a pull request Dec 13, 2024 that will close this issue
Fixes #1698: prevent use-after-free of qd_link_t on session close #1699
Merged
kgiusti added a commit to kgiusti/skupper-router that referenced this issue Dec 16, 2024
@kgiusti
Fixes skupperproject#1698: prevent use-after-free of qd_link_t on ses…
d623124 
…sion close

Previously the detach handler might free the qd_link_t but it was not
consistent. This patch moves the qd_link_t cleanup to the container.
kgiusti added a commit that referenced this issue Dec 16, 2024
@kgiusti
Fixes #1698: prevent use-after-free of qd_link_t on session close (#1699
f2b8092 
)

Previously the detach handler might free the qd_link_t but it was not
consistent. This patch moves the qd_link_t cleanup to the container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgiusti kgiusti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1698: prevent use-after-free of qd_link_t on session close kgiusti/skupper-router
1 participant
@kgiusti