-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe): edit create problem page #1923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late up hint and source
juhyeong0505
added
⛳️ team-frontend
💡 feature-admin
Features for admin & group manager
next-js
Next.js features
labels
Aug 5, 2024
juhyeong0505
requested review from
jwoojin9,
jihorobert,
B0XERCAT,
youznn and
Kimhyojung0810
August 5, 2024 09:16
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jihorobert
reviewed
Aug 9, 2024
@juhyeong0505 해당 브랜치에서 주석들 지워주고 머지하면 될것같아요! |
jihorobert
approved these changes
Aug 26, 2024
jwoojin9
pushed a commit
that referenced
this pull request
Aug 28, 2024
* feat(fe): edit popover text and padding * chore(fe): add space between title and visible, add left margin to angleleft * chore(fe): add color to radio button, adjust gaps * feat(fe): change checkbox design, delete tag select, change box order * chore(fe): change toggle color, move template field * chore(fe): move title, add space between title and visible, move template up hint and source * fix(fe): comment out tags and get tag * chore(fe): delete comment about tag feature * chore(fe): delete comments * chore(fe): delete comments --------- Co-authored-by: Jiho Park <[email protected]>
jwoojin9
added a commit
that referenced
this pull request
Aug 30, 2024
* feat(fe): show modal in admin contest * feat(fe): add contest create modal * feat(fe): add alert to contest create and edit * feat(be): add get-contest-submission-informations api (#1894) * feat(be): add contest-submission-result model * chore(be): rename contest-submission-result to contest-submission-information * chore(be): set nullability of fields in contest-submission-information * feat(be): add get-contest-submission-informations api * chore(be): rename * test(be): add test * docs(be): add docs * chore(be): rename files and add fields on contest-submission-summary-for-one * feat(be): implement combine score summary and submissions * chore(be): comment test * feat(be): add problem-id option * fix(be): fix wrong type * docs(be): rename files * docs(be): rename file * docs(be): rename files * fix(be): fix ContestSubmissionSummaryForOne model * docs(be): remove resolved todo * chore(be): lint contest.service.spec * fix(be): don't throw error when no submission --------- Co-authored-by: 강민석 <[email protected]> Co-authored-by: jimin9038 <[email protected]> * fix(fe): redirect to home when user logged out (#2027) * feat(infra): add capacity provider strategy to ecs cluster (#2026) * feat(infra): add capacity provider strategy to ecs cluster * feat(infra): modify weight of capacity provider strategy to 1 * feat(fe): edit create problem page (#1923) * feat(fe): edit popover text and padding * chore(fe): add space between title and visible, add left margin to angleleft * chore(fe): add color to radio button, adjust gaps * feat(fe): change checkbox design, delete tag select, change box order * chore(fe): change toggle color, move template field * chore(fe): move title, add space between title and visible, move template up hint and source * fix(fe): comment out tags and get tag * chore(fe): delete comment about tag feature * chore(fe): delete comments * chore(fe): delete comments --------- Co-authored-by: Jiho Park <[email protected]> * chore(fe): hide test button (#2028) Co-authored-by: Jiho Park <[email protected]> * chore(fe): edit admin contest toggle title text (#2030) * feat(be): implement getContestScoreSummaries api (#2029) * feat(be): implement getContestScoreSummaries * fix(be): make userContestScoreSummaryWithUserInfo model to return user * docs(be): getcontestscoresummaries * fix(be): rename get contest score api * feat(be): sperate testcases into sample or hidden (#2000) * feat(be): delete example-io and add is-hidden-testcase field * feat(be): modify get-problem api to return testcases * docs(be): add is-hidden-testcase * fix(be): rename variable name of problem-response * docs(be): add problem-testcase field * docs(be): add todo on create-testcases - TODO: 테스트케이스 저장 방식 S3 => DB 직접 저장으로 변경 시 함수 삭제 * chore(be): change is-hidden-testcase to is-hidden * fix(fe): erase sample in admin, change samples to problem testcase in client --------- Co-authored-by: b0xercat <[email protected]> Co-authored-by: jimin9038 <[email protected]> * feat(fe): add contest create modal * feat(fe): add modal to problem create and edit * feat(fe): make confirmnavigation reusable * fix(fe): disable confirm when creating --------- Co-authored-by: Jaehyeon Kim <[email protected]> Co-authored-by: 강민석 <[email protected]> Co-authored-by: jimin9038 <[email protected]> Co-authored-by: YooJin Lee <[email protected]> Co-authored-by: Eunsu Kang <[email protected]> Co-authored-by: 박주형 <[email protected]> Co-authored-by: Jiho Park <[email protected]> Co-authored-by: Kwon Seo Jin <[email protected]> Co-authored-by: b0xercat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1916
Title 인풋 너비 길이 조정, Visible popover 문구 수정, Radio 버튼 색 수정밑 gap수정, Info에서 체크박스 Select component 수정, Templates 컴포넌트 위치 수정, Switch toggle 색상 수정
Additional context
Testcase 부분 제외 리디자인 완료
Before submitting the PR, please make sure you do the following
fixes #123
).