From 4e2c669412f96538317036cf15dcf54fb0c124af Mon Sep 17 00:00:00 2001 From: Heavensbee <65532083+beeheavens@users.noreply.github.com> Date: Thu, 15 Aug 2024 19:50:51 +0900 Subject: [PATCH] fix(cd): hide minio's id and password (#1952) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 기존에는 minIO의 ID와 PW가 파일에 노출되어 있었다. Github Actions의 secrets를 사용해 해당 값을 환경 변수로 설정해 주어 사용함으로써 노출을 피할 수 있다. --- docker-compose.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index c46b5da64d..fa176184d8 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -27,8 +27,8 @@ services: - 9001:9001 command: server /data --console-address ":9001" environment: - MINIO_ROOT_USER: skku - MINIO_ROOT_PASSWORD: skku1234 + MINIO_ROOT_USER: ${MINIO_ROOT_USER} + MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} volumes: - codedang-storage:/data