Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: buf actions #725

Merged
merged 7 commits into from
Sep 5, 2024
Merged

ci: buf actions #725

merged 7 commits into from
Sep 5, 2024

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Sep 4, 2024

add buf actions to ci:

  • checks breaking changes on PR
  • pushes proto changes to BSR on merge main

@technicallyty
Copy link
Contributor Author

blocked waiting on adding buf secret to repo

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.97%. Comparing base (36c682c) to head (584d132).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   55.97%   55.97%           
=======================================
  Files         206      206           
  Lines       11475    11475           
=======================================
  Hits         6423     6423           
  Misses       4452     4452           
  Partials      600      600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technicallyty technicallyty marked this pull request as ready for review September 4, 2024 22:11

This comment has been minimized.

This comment has been minimized.

@technicallyty

This comment has been minimized.

Copy link

github-actions bot commented Sep 4, 2024

⌛ check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions 🪄

Create a deploy key and secret

(
  set -e
  brand=check-spelling; repo='skip-mev/connect'; SECRET_NAME=CHECK_SPELLING
  cd "$(mktemp -d)"
  ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo"
  gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot"
  gh secret -R "$repo" set "$SECRET_NAME" < "./$brand"
)

Configure update job in workflow to use secret

If the .github/workflows/spell.yml workflow Spell checking job doesn't already have the check-spelling/with/ssh_key, then add them:

    name: Spell checking
    ...
    steps:
    ...
    - name: apply spelling updates
      uses: ${action_ref:-check-spelling/check-spelling@...}
      with:
        checkout: true
+       ssh_key: "${{ secrets.CHECK_SPELLING }}"

To trigger another validation round and hopefully a ✅, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

@technicallyty technicallyty enabled auto-merge (squash) September 5, 2024 15:31
@technicallyty technicallyty merged commit 2d6a5f5 into main Sep 5, 2024
14 checks passed
@technicallyty technicallyty deleted the tyler/buf_ci branch September 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants