Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into replacing template literals with react #39

Open
sketchbuch opened this issue Nov 2, 2021 · 0 comments
Open

Look into replacing template literals with react #39

sketchbuch opened this issue Nov 2, 2021 · 0 comments
Labels
enhancement New feature or request under consideration

Comments

@sketchbuch
Copy link
Owner

Other extensions with webviews use react, doing so would require changing the way state is handled. Currently state triggers a re-render which is pointless with react since react should manage updates and just get unmounted/mounted.

Conside using post message to update react instea of triggering vscode to completely re-render the view.
@sketchbuch sketchbuch added enhancement New feature or request under consideration labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request under consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sketchbuch