Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts info #40

Open
haydn opened this issue Jan 23, 2020 · 1 comment · May be fixed by #46
Open

Add keyboard shortcuts info #40

haydn opened this issue Jan 23, 2020 · 1 comment · May be fixed by #46
Assignees
Milestone

Comments

@haydn
Copy link
Member

haydn commented Jan 23, 2020

Objective

Add a button to the bottom of the right panel that opens a modal explaining all the keyboard shortcuts available.

Here's an example from Dropbox Paper:

image

image

Trello has a similar thing:

image

Rationale

There is a lot of functionality that can only be accessed via keyboard shortcuts at the moment. Most users aren't going to know about them without a lot of trial-and-error. This is a pretty lightweight and flexible way to make that information available.

Notes

  • We should make a standalone Modal component using portals so that we can reuse it for other places where we need modals.
  • It'd be nice if the keyboard shortcut modal could also be displayed if the use presses SHIFT-?.
@Mxchaeltrxn
Copy link
Member

I can do this one

@Mxchaeltrxn Mxchaeltrxn linked a pull request Jan 25, 2020 that will close this issue
@haydn haydn added this to the v0.1 milestone Feb 16, 2020
@haydn haydn modified the milestones: v0.2, v1.0, v0.3 Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants