Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT: Drawers #2397

Closed
endigo9740 opened this issue Jan 3, 2024 · 5 comments
Closed

NEXT: Drawers #2397

endigo9740 opened this issue Jan 3, 2024 · 5 comments
Assignees
Labels
React - Incomplete The React portion of this feature is incomplete Svelte - Incomplete The Svelte portion of this feature is incomplete
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Jan 3, 2024

Warning

This issue is a work in progress.

This will act as a hub to centralize this information.

Maintainer Requests

The following requests are coming straight from the Skeleton team. These are highly likely be implemented:

  • This should borrow heavily from the updated Modal system
  • Allow multiple drawers to be displayed at once (stacking)
  • (expect more soon)

Community Requests

The following requests have come from the community and are under consideration:

Bugs and Issues

  • n/a

Feedback

If you have additional updates or requests for this feature, please do so in the comments section below.

@endigo9740 endigo9740 added enhancement New feature or request feature request Request a feature or introduce and update to the project. labels Jan 3, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Jan 3, 2024
@endigo9740 endigo9740 added Svelte - Incomplete The Svelte portion of this feature is incomplete React - Incomplete The React portion of this feature is incomplete and removed enhancement New feature or request feature request Request a feature or introduce and update to the project. labels Jan 3, 2024
@ImGajeed76
Copy link

Hi there, I got a feature request! 😊

It would be very nice if we could pass easing functions to the drawers open and close transitions.

@ImGajeed76
Copy link

Hi again, I got another one.

It would be nice if you could just swipe to close the drawers. (mostly for mobile)

@endigo9740 endigo9740 self-assigned this Apr 11, 2024
@jhechtf
Copy link

jhechtf commented Apr 17, 2024

Please move drawers away from the singleton pattern.

@apple-phi
Copy link

apple-phi commented Apr 20, 2024

Over in the Discord, there was a brief discussion about shallow routing for Drawers in v2, and @Sarenor asked me to send my solution for this here. I haven't done properly extensive testing on this, but it seems to work.

function openDrawer(): void {
	pushState('', { showDrawer: true });
	drawerStore.open({ position: 'right' });
}
<script lang="ts">
	function closeDrawer(): void {
		history.back();
	}
	$: $drawerStore.open = $page.state.showDrawer;
</script>

<Drawer>
...
</Drawer>

For type safety, you also need to set the interface for the page state in app.d.ts.

Ref:

@endigo9740
Copy link
Contributor Author

endigo9740 commented May 24, 2024

In v3, we're going to combine modals/drawers/toasts into a unified "overlay system":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
React - Incomplete The React portion of this feature is incomplete Svelte - Incomplete The Svelte portion of this feature is incomplete
Projects
None yet
Development

No branches or pull requests

4 participants