Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint violations inserting commands after a screen session or a subshell ends #6

Open
GoogleCodeExporter opened this issue Jul 3, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

So far this has been seen in zsh, but not confirmed in bash.

What steps will reproduce the problem?
1. source the shell code from a new terminal
2. open a screen session or a subshell
3. enter commands and exit the screen session or subshell
4. enter more commands in the original parent shell

What is the expected output? What do you see instead?

I expect all history to be logged.  In practice, I see constraint violations 
inserting commands since the key uses only the command number and session id.  
Since subshells and screen sessions inherit these values, the constraints are 
not exclusive enough.

We should probably also include the shell PID or possibly the command itself

Please use labels and text to provide additional information.


Original issue reported on code.google.com by [email protected] on 30 Sep 2011 at 7:08

@GoogleCodeExporter
Copy link
Author

since PID is not already in the commands table, we can use SHLVL instead.  Both 
screen and subshells increment this value, so it should be safe.

Original comment by [email protected] on 30 Sep 2011 at 7:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant