Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Gameboard grid implementation #172

Merged

Conversation

josephchimebuka
Copy link
Contributor

@josephchimebuka josephchimebuka commented Dec 23, 2024

closes #131

@josephchimebuka josephchimebuka changed the title Feat gameboard grid implementation Feat: Gameboard grid implementation Dec 23, 2024
Copy link
Collaborator

@princeibs princeibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@princeibs
Copy link
Collaborator

@josephchimebuka any update on this?

@josephchimebuka
Copy link
Contributor Author

Yes ser there's... Give me today and I'll send it

Copy link
Collaborator

@princeibs princeibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve conflicts and ensure the CI is passing?

@josephchimebuka
Copy link
Contributor Author

Can you resolve conflicts and ensure the CI is passing?

Yes ser I will resolve it right now... I did it before some new PRs were merged

@josephchimebuka
Copy link
Contributor Author

@princeibs there are no branch conflicts now ser... And I ran lint on local no errors

@princeibs
Copy link
Collaborator

image
Still failing

@josephchimebuka
Copy link
Contributor Author

Hello @princeibs,...I’ve fixed the errors locally,it should pass CI now

@princeibs princeibs merged commit bc88c3f into sivicstudio:dev Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game Board Grid Implementation with Consideration for Other Board Provided Board Skins for Easy Customization.
2 participants