Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

ChromeUserTimings on a Webpagetest RepeatView are not saved by name in Graphite #4

Open
cmarshall3 opened this issue May 6, 2020 · 5 comments

Comments

@cmarshall3
Copy link

When running a webpagetest test in sitespeed.io:12.8.0 on Ubuntu 18.04.4 LTS with a webpagetest-secrets config file as follows:

{
"extends": "/config/secrets.json",
"webpagetest": {
"connectivity": "5mbps",
"timeout": 4000,
"timeline": true,
"first": false,
"firstViewOnly": false,
"cached": true,
"repeatView": true,
"rvonly": false,
"includeRepeatView": true,
"include-repeat-view": true,
"host": "http://nn.nn.nn.nn",
"location": "eu-west-2-linux:Chrome",
"key": "****************************************",
"aftRenderingTime": true,
"video": true,
"lighthouse": true
}
}

The ChromeUserTimings are stored as numbers, rather than with the correct metric names.

Whilst firstView is correct:

FirstView

repeatView for the same test is not:

RepeatView

The json returned by webpagetest correctly names the ChromeUserTimings in the repeatview.

@soulgalore
Copy link
Member

My guess is that the numbers comes from that WebPageTest returns an array, but I need to look into it to know. If you have any free time and can have a look, please do!

@cmarshall3
Copy link
Author

Thanks Peter,

I’m not sure which part of the sitespeed code consumes the json from webpagetest but I’ve spent a bit of time looking at the firstview and repeatview data structures and can’t see a difference between them.

I’m attaching the prettified json payloads for the two median tests (firstview and repeatview) for the following test:

https://www.webpagetest.org/results.php?test=200511_XN_76fd3142c02bed24177f2052d9238d9a

MEDIAN.trace-3-wpt-firstView.txt

MEDIAN.trace-1-wpt-repeatView.txt

@soulgalore
Copy link
Member

Hi @cmarshall3 let me have a go the coming days, I almost never tests with repeat views so maybe there's a bug at our side.

@soulgalore
Copy link
Member

I still need to test this.

@cmarshall3
Copy link
Author

Thanks Peter.

@soulgalore soulgalore transferred this issue from sitespeedio/sitespeed.io Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants