-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Await for the gecko profiler start instead of adding a synthetic delay #1857
Comments
Hi @canova ah cool, so then I can just remove the extra wait and it will work as it should right? |
Yes, it should work as expected without the extra wait if we properly await the |
Feature/improvement
Currently browsertime adds a delay after the gecko profiler start command:
browsertime/lib/firefox/geckoProfiler.js
Lines 89 to 90 in 79e9b0e
This was because previously we didn't have a way to properly await for the profiler start since all the processes start the profiler individually. But this year, with the Bug 1668867, we've started to return a Promise instead from the
Services.profiler.StartProfiler
API and it resolves when all the processes start profiling. This way we can start the profiler and await until it's ready without needing an additional settle delay.Here's the profiler start command in browsertime:
browsertime/lib/firefox/geckoProfiler.js
Lines 74 to 77 in 79e9b0e
Here's an example in our tests: https://searchfox.org/mozilla-central/rev/0a2eba79c24300ce0539f91c1bebac2e75264e58/tools/profiler/tests/xpcshell/test_active_configuration.js#24-30
The text was updated successfully, but these errors were encountered: