-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin won't compile using nativescript 4 #40
Comments
Last PR apparently added support Your error says "Failed to build plugin nativescript-social-share"? |
Sorry about this, I copied the wrong error message.
|
@dammynex try to update library, in my case work
|
Okay, thanks. I'll try that |
I updated to 4, and made some changes, both demo apps now work fine with no real changes (superficial at best) to the plugin code itself... https://www.screencast.com/t/sMcEEG8D I'll re-publish, but can you dump me the FULL terminal error message? |
Up on npm now |
Hi! How did you solve the problem? I think I have the same problem.
And then
|
The jcenter url returns a 404. Is there an update or known workaround? |
This is the fix for it right? NativeScript/android@891bd09#diff-f0ec8276fd420875920a31231349a391 I think it's in 4.1.1? |
Unfortunately, no. Even with google listed first, for the support-v4 AAR, it tries to get it from JCenter:
|
Can you try with the latest plugin push to npm... whatever is going on here I don't think is specific to this plugin, but eddy made a massive PR, and demo works fine |
Upgrading everything to the latest doesn't fix it. I did look into the
...at least in the allprojects section. It seems like it's not checking anything but jcenter. |
Where am i fixing that though? I don't specify that anywhere.
I'll see what the team says
…On Wed, Jun 27, 2018, 4:52 PM Matt Fox ***@***.***> wrote:
Upgrading everything to the latest doesn't fix it. I did look into the
platforms/tempPlugin/nativescript_google_analytics folder after a build
attempt, and the build.gradle file there has the jcenter() repository
listed first:
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.1.2'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
}
allprojects {
repositories {
jcenter()
mavenLocal()
mavenCentral()
maven {
url 'https://maven.google.com/'
name 'Google'
}
}
}
apply plugin: 'com.android.library'
def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 24 }
def computeBuildToolsVersion = { ->
project.hasProperty("buildToolsVersion") ? buildToolsVersion : "27.0.3"
}
android {
compileSdkVersion computeCompileSdkVersion()
buildToolsVersion computeBuildToolsVersion()
defaultConfig {
targetSdkVersion 26
versionCode 1
versionName "1.0"
}
}
dependencies {
def supportVer = "27.0.1"
if (project.hasProperty("supportVersion")) {
supportVer = supportVersion
}
compileOnly "com.android.support:support-v4:$supportVer"
compileOnly "com.android.support:appcompat-v7:$supportVer"
}
dependencies {
// [START gms_compile]
def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : '+'
compile "com.google.android.gms:play-services-analytics:$googlePlayServicesVersion"
// [END gms_compile]
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeI6M6XXcY-KcE52spC_vnMk_s9AMmYks5uA_BxgaJpZM4Tsx2O>
.
|
Looks like this is still an open issue with the android runtime: NativeScript/android#1081 This issue can be closed, but hope it helps someone else. |
I recently updated to nativescript 4.0.
And the plugin stopped working, I even created a new project and installed the plugin and still won't compile
"Failed to build plugin nativescript-social-share : Error: Command failed: ./gradlew -p /home/brainex/Projects/mp3faka/platforms/tempPlugin/nativescript_social_share assembleRelease -PcompileSdk=android-25 -PbuildToolsVersion=26.0.2 -PsupportVersion=25.3.1"
The text was updated successfully, but these errors were encountered: