Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROTO.warn used before it's defined #16

Open
adambom opened this issue Oct 25, 2013 · 0 comments
Open

PROTO.warn used before it's defined #16

adambom opened this issue Oct 25, 2013 · 0 comments

Comments

@adambom
Copy link

adambom commented Oct 25, 2013

The definition of PROTO.DefineProperty calls PROTO.warn on lines 83 and 87 of protobuf.js. However, PROTO.warn is not defined until line 118. If a browser like IE8 does not support DefineProperty, then it will attempt to call PROTO.warn before it's defined.
adambom added a commit to adambom/protojs that referenced this issue Oct 25, 2013
@adambom
Move PROTO.warn above its first use, fixes sirikata#16
74a81d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adambom