Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to download the video (week starting 12/23) #3591

Open
3 tasks done
dagandrew opened this issue Nov 30, 2024 · 9 comments
Open
3 tasks done

[Bug]: Unable to download the video (week starting 12/23) #3591

dagandrew opened this issue Nov 30, 2024 · 9 comments
Assignees
Labels
awaiting-release Will be released with next update bug Something isn't working

Comments

@dagandrew
Copy link

What happened?

it says that the media is missing, but you can download it from the website
image
and it shows an error like this
image

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Do '....'
  4. See error

What did you expect to happen?

I thought it was something with jwpub, but when you go to JWL it works okay

Version

latest

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Screenshots

No response

Additional context

No response

Confirmations

  • I confirm that I have read the documentation website.
  • I confirm that I have searched through the existing issues to make sure my bug report is not a duplicate.
  • I confirm that I have searched through the existing discussions to make sure my bug report is not a duplicate.
@dagandrew dagandrew added the bug Something isn't working label Nov 30, 2024
@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Nov 30, 2024

This has been fixed in baeb118 and will be released in time before the 23rd.

@mtdvlpr mtdvlpr added the awaiting-release Will be released with next update label Nov 30, 2024
@ux-git
Copy link
Contributor

ux-git commented Nov 30, 2024

@mtdvlpr btw can the app detect the meeting media that are not yet available for download (like certain videos that are available only one week before the meetings), to label them differently? Just to give users the context that it's not an app's failure, but the video is not yet available at all, but will be automatically downloaded as soon as it becomes available.

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 1, 2024

@mtdvlpr btw can the app detect the meeting media that are not yet available for download (like certain videos that are available only one week before the meetings), to label them differently? Just to give users the context that it's not an app's failure, but the video is not yet available at all, but will be automatically downloaded as soon as it becomes available.

I think we can. The title should already be correct (if not for this bug). So instead of the 20204408_U_1 it should display the same title as does JW Library when a video is unavailable. Is that what you mean or did you mean the description text below that states that the media item is missing?

@ux-git
Copy link
Contributor

ux-git commented Dec 1, 2024

@mtdvlpr I guess both. The description will also be useful to update since the video can't be directly imported. User has just to wait and keep calm :)

@sircharlo
Copy link
Owner

This has been fixed in baeb118 and will be released in time before the 23rd.

Slated for release in the coming week!

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 2, 2024

@mtdvlpr I guess both. The description will also be useful to update since the video can't be directly imported. User has just to wait and keep calm :)

I'm not that familiar with the current fetching logic (yet). @sircharlo, if you feel it's worthwhile, could you implement this?

@sircharlo
Copy link
Owner

@mtdvlpr I guess both. The description will also be useful to update since the video can't be directly imported. User has just to wait and keep calm :)

I'm not that familiar with the current fetching logic (yet). @sircharlo, if you feel it's worthwhile, could you implement this?

Without going into too many specifics, I won't be able to do this without significantly complicating the underlying logic and methods used for media extraction. I feel the current approach of showing the slot where the media will go is sufficient to help most media operators troubleshoot the issue.

Would it be worth it to have a link to open the relevant meeting page in WOL?

@sircharlo
Copy link
Owner

For context: this is what the user sees in JWL when a non-existent video is referenced:

image

And in MMM:

image

@ux-git
Copy link
Contributor

ux-git commented Dec 2, 2024

@sircharlo well, yeah... Seems like the 5% of improvement with 95% of the effort.

I think the link to the corresponding program on WOL would make sense with a context of "Please double check the availability of the video on the WOL. If it's currently not available, the app will automatically download it as soon as it becomes available".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-release Will be released with next update bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants