Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implied units and just use units everywhere #38

Closed
kjohnsen opened this issue Sep 12, 2023 · 0 comments · Fixed by #54
Closed

Remove implied units and just use units everywhere #38

kjohnsen opened this issue Sep 12, 2023 · 0 comments · Fixed by #54
Labels
good first issue Good for newcomers

Comments

@kjohnsen
Copy link
Member

kjohnsen commented Sep 12, 2023

I had all the code surrounding the IOProcessor not use units, the reasoning being that we could plug in a non-Python controller that wouldn't have the same Brian unit system. But this is silly---the Python IOProcessor would need to wrap such a foreign controller and it would be trivial to wrap/unwrap with unis

WIP on #43

@kjohnsen kjohnsen added the good first issue Good for newcomers label May 14, 2024
@kjohnsen kjohnsen mentioned this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant