SIPX-883: Fix/Workaround for Missing CDRs for failed calls (4xx responses) #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calls with e.g. 404 SIP Responses will marked as terminated this creates correct CDRs for failed calls again.
This reverts commit 5f6590d.
it looks like the used cleaner -> terminator stuff is not working anymore the whole cleanup processes aren't executed at all (as far as I can see and debug) This workaround works. One should check if the used dependencies have changend and cause the problems.
- added TODO comment
cbeyersdorf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes for SIPX-865 revert (as SIPX-883 is the real problem and changes made for SIPX-865 cause additional problems).
Workaround for SIPX-883 for me it looks like the problem is caused as the background houskeeping jobs are not working anymore.
For me it looks like something has changed inside the Monitor module from ruby or it is the change to the newer ruby version?
I had added logging to the houskeeping and could see they are never executed at all.
So I've removed the background threads and added the function calls to the main loop of state.
After this change all CDRs are generated correctly even the 4xx ones.
As I'm not an ruby expert (these was my first experience with ruby) I have not time to deep further into the problem.
Maybe someone more experienced in ruby can look into the lib/utils/cleaner.rb and or the lib/utils/terminator.rb and can find and fix the real problem?
I hope this will help.